Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Bubble Node): Fix pagination issue when returning all objects #5483

Merged
merged 1 commit into from
Feb 16, 2023
Merged

fix(Bubble Node): Fix pagination issue when returning all objects #5483

merged 1 commit into from
Feb 16, 2023

Conversation

Joffcom
Copy link
Member

@Joffcom Joffcom commented Feb 15, 2023 •
edited by that-one-tom
Loading

Github issue / Community forum post (link here to close automatically): https://community.n8n.io/t/bubble-get-all-hanging-fails/23079

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Feb 15, 2023
that-one-tom
that-one-tom approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@that-one-tom that-one-tom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, tested with 1, 2 and 3 results pages. Also working when there are 0 results.

@guillim
Copy link

guillim commented Feb 15, 2023

I created the issue for the community here, adding the backlinks as well to this repo
https://community.n8n.io/t/bubble-get-all-hanging-fails/23079

@that-one-tom
Copy link
Contributor

I created the issue for the community here, adding the backlinks as well to this repo https://community.n8n.io/t/bubble-get-all-hanging-fails/23079

Thanks for reaching out on the forum @guillim :)

You should get a notification on the forum automatically once this is resolved.

@guillim
Copy link

guillim commented Feb 15, 2023

I created the issue for the community here, adding the backlinks as well to this repo https://community.n8n.io/t/bubble-get-all-hanging-fails/23079

Thanks for reaching out on the forum @guillim :)

You should get a notification on the forum automatically once this is resolved.

any timeline in mind ? i mean hours/days/weeks ? (our production notification tool is down right now)

@Joffcom
Copy link
Member Author

Joffcom commented Feb 16, 2023

Hey @guillim

Will be merging today and it will be in the next release which will be this week.

For self hosted installs it will be available as soon as the release goes live for cloud it will take a bit longer.

If this is urgent for you a temporary solution would be to use the http request node and manually build out the request and loop.

@Joffcom Joffcom merged commit 1a20fd9 into master Feb 16, 2023
@Joffcom Joffcom deleted the NODE-302 branch February 16, 2023 09:01
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Feb 16, 2023
@guillim
Copy link

guillim commented Feb 16, 2023

how long from a github release to a cloud release on average ?

@janober
Copy link
Member

janober commented Feb 16, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Feb 16, 2023
@Joffcom
Copy link
Member Author

Joffcom commented Feb 17, 2023

@guillim it all depends on if any issues are found so it could be a few days or it could be a week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@that-one-tom that-one-tom that-one-tom approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Joffcom @guillim @that-one-tom @janober